NMichas commented on issue #291:
URL:
https://github.com/apache/apisix-helm-chart/issues/291#issuecomment-1134875260
So, PR is now updated:
- Ingress
Ingress chart can now be installed in the same namespace as the admin
service without having to pass `--set` parameters to Helm. In addition,
ingress' URL of the admin service can be created automatically if missing,
prefixed with the release name. From `values.yaml`:
```
apisix:
# The name of the APISIX admin service. Leave it empty to use <Release
name>-apisix-admin.
serviceName: ""
# The namespace of APISIX admin service. Leave it empty to use the
release namespace.
serviceNamespace: ""
```
- Dashboard
The URL of etcd is now automatically prefixed with the release name, when
left empty. This allows the dashboard to be installed into a custom namespace
without having to pass `--set` parameters to Helm. From `values.yaml`:
```
config:
conf:
...
etcd:
# Supports defining multiple etcd host addresses for an etcd cluster.
# Leave it undefined to use <Release name>-etcd:2379 as an endpoint.
# endpoints:
# - apisix-etcd:2379
```
The above PR allows you to:
- Install admin with dashboard and/or ingress in one go on the same
namespace using any Helm release name (i.e. `helm install myapp
https://charts.apiseven.com --set dashboard.enabled=true --set
ingress-controller.enabled=true` should now work anywhere).
- Create a meta-chart for your own project having all three APISIX charts as
dependencies, without having to specify any additional configuration for the
namespace or the Helm release name (that's my use case).
- If you wish so, you can still manually specify `apisix.serviceName`,
`apisix.serviceNamespace`, and `config.conf.etcd.endpoints` via `--set`; in
that case the behaviour of this PR's charts is the same as before this PR (in
fact, manual configuration is still necessary if you decide to install the
three charts individually).
Please let me know if you see anything wrong and I'm happy to modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
