tokers commented on code in PR #302:
URL: https://github.com/apache/apisix-helm-chart/pull/302#discussion_r885136594
##########
charts/apisix/values.yaml:
##########
@@ -135,10 +135,12 @@ gateway:
enabled: true
servicePort: 80
containerPort: 9080
+ hostPort: 80
Review Comment:
This field should be commented by default.
##########
charts/apisix/templates/deployment.yaml:
##########
@@ -65,9 +65,11 @@ spec:
- name: http
containerPort: {{ .Values.gateway.http.containerPort }}
protocol: TCP
+ hostPort: {{ .Values.gateway.http.hostPort }}
Review Comment:
Here we should add an `if` block to check whether the `hostPort` is
configured. Or hostPort is always enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
