tao12345666333 commented on code in PR #1031:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r887520349
##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o
jsonpath='{ .spec.versions[*].
If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply
the latest version of `ApisixRoute`.
Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and
APISIX Ingress. Please refer to this
[link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change
Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key,
we also need to change the Admin API key in apisix-ingress-controller. There
are two different ways to implement the requirements here.
+
+For the first method, we need to modify the Admin API credentials values in
both the `apisix/values.yaml` and
`apisix/apisix-ingress-controller/values.yaml` files. You can refer to these
two links(apisix's
[values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#:~:text=admin%3A%20edd1c9f034335f136f87ad84b625c8f1)
&& apisix-ingress-controller's
[values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#:~:text=adminKey%3A%20%22edd1c9f034335f136f87ad84b625c8f1%22)).
Review Comment:
please use permalink
https://github.com/apache/apisix-helm-chart/blob/57cdbe461765cd49af2195cc6a1976cc55262e9b/charts/apisix/values.yaml#L181
https://github.com/apache/apisix-helm-chart/blob/57cdbe461765cd49af2195cc6a1976cc55262e9b/charts/apisix-ingress-controller/values.yaml#L128
##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o
jsonpath='{ .spec.versions[*].
If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply
the latest version of `ApisixRoute`.
Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and
APISIX Ingress. Please refer to this
[link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change
Apache APISIX.
Review Comment:
you should link to
https://apisix.apache.org/docs/apisix/how-to-build/#updating-admin-api-key
##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o
jsonpath='{ .spec.versions[*].
If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply
the latest version of `ApisixRoute`.
Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and
APISIX Ingress. Please refer to this
[link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change
Apache APISIX.
Review Comment:
And modify the admin key just to protect Apache APISIX
##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o
jsonpath='{ .spec.versions[*].
If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply
the latest version of `ApisixRoute`.
Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and
APISIX Ingress. Please refer to this
[link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change
Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key,
we also need to change the Admin API key in apisix-ingress-controller. There
are two different ways to implement the requirements here.
+
+For the first method, we need to modify the Admin API credentials values in
both the `apisix/values.yaml` and
`apisix/apisix-ingress-controller/values.yaml` files. You can refer to these
two links(apisix's
[values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#:~:text=admin%3A%20edd1c9f034335f136f87ad84b625c8f1)
&& apisix-ingress-controller's
[values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#:~:text=adminKey%3A%20%22edd1c9f034335f136f87ad84b625c8f1%22)).
+
+Another method, you can just pass `--set
ingress-controller.config.apisix.adminKey=<Your new admin key>` to `helm
install` command.
Review Comment:
In the first method, you modify the admin key of APISIX and APISIX Ingress,
but in the second method, you only modify the admin key of APISIX Ingress.
Please keep them consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
