Jary-mf commented on code in PR #7317:
URL: https://github.com/apache/apisix/pull/7317#discussion_r905753481


##########
apisix/plugins/proxy-rewrite.lua:
##########
@@ -185,6 +185,7 @@ function _M.rewrite(conf, ctx)
         upstream_uri = core.utils.uri_safe_encode(upstream_uri)
     end
 
+    ctx.var.upstream_uri = nil

Review Comment:
   maybe ctx.var.upstream_uri = nil is fine ? because there will be 
unconditionally assigned to ctx.var.upstream_uri again。see lines 189 to 197



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to