kenhys opened a new pull request, #7351:
URL: https://github.com/apache/apisix/pull/7351

   ### Description
   
   Already header file for OpenSSL (openresty-openssl111-devel) is
   checked, so do same thing for PCRE.
   
   Without this fix, even though openresty-pcre-devel is installed, make
   deps fails like this:
   
     Error: Failed installing dependency: 
https://luarocks.org/jsonschema-0.9.8-0.src.rock - Failed installing 
dependency: https://luarocks.org/lrexlib-pcre-2.9.1-1.src.rock - Could not find 
header file for PCRE
       No file pcre.h in /usr/local/include
       No file pcre.h in /usr/include
       No file pcre.h in /include
     You may have to install PCRE in your system and/or pass PCRE_DIR or 
PCRE_INCDIR to the luarocks command.
     Example: luarocks install lrexlib-pcre PCRE_DIR=/usr/local
   
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   NOTE: utils/install-dependencies.sh or ci/centos7-ci.sh explicitly installs 
pcre-devel instead
   of openresty-pcre-devel, does it intentional?
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to