soulbird commented on code in PR #7410:
URL: https://github.com/apache/apisix/pull/7410#discussion_r916395800
##########
Makefile:
##########
@@ -115,6 +115,7 @@ define func_check_folder
fi
endef
+test = t/
Review Comment:
This definition doesn't look neat enough. I suggest you define and write at
the top of the code:
````
TEST_CASES ?= t/
```
##########
Makefile:
##########
@@ -115,6 +115,7 @@ define func_check_folder
fi
endef
+test = t/
Review Comment:
This definition doesn't look neat enough. I suggest you define and write at
the top of the code:
```
TEST_CASES ?= t/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
