lingsamuel commented on code in PR #1140:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1140#discussion_r916638751
##########
test/e2e/suite-endpoints/endpoints.go:
##########
@@ -21,17 +21,27 @@ import (
ginkgo "github.com/onsi/ginkgo/v2"
"github.com/stretchr/testify/assert"
+ "k8s.io/apimachinery/pkg/util/wait"
"github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
)
+func ensureNumListUpstreamNodes(s *scaffold.Scaffold, upsNum int, upsNodesNum
int) error {
Review Comment:
I think this function could be a public scaffold function instead of a
package private one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
