Michael Blow has posted comments on this change. Change subject: SONAR: Collection, misc fixes ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/881/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggregateIntoGroupbyRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushAggregateIntoGroupbyRule.java: Line 106: for (Pair<GroupByOperator, Integer> remove : removeList) { Yingyi- once fixing the remove call, I had to defer the removal until after iterating over all the gby vars, otherwise there were failures in later iterations caused by shifting indexes in the nested plans array. -- To view, visit https://asterix-gerrit.ics.uci.edu/881 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie68a269bab4d1b2bdc628a5f09b9afff3882e09e Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
