Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1428: Config-management improvements for AsterixDB
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/887/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCServiceConfig.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCServiceConfig.java:

Line 52:             usage = "Filename to log NC output ('-' for stdout of NC 
service; default: $HOME/nc.log)")
Just use a log directory here and leave the name of the file to the NC.


Line 79:             logfile = System.getProperty("user.home") + File.separator 
+ "nc.log";
Put into "app.home"/logs ?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/887
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f2ad32d489ffc27adbb06aebcc1f22a9fcf784e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to