Chris Hillery has submitted this change and it was merged. Change subject: Improve creating log directory ......................................................................
Improve creating log directory Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6 Reviewed-on: https://asterix-gerrit.ics.uci.edu/890 Reviewed-by: Till Westmann <[email protected]> Tested-by: Jenkins <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java index ea220c1..e3fe959 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java @@ -140,7 +140,10 @@ pb.redirectErrorStream(true); File log = new File(config.logdir); if (! log.mkdirs()) { - throw new IOException(config.logdir + ": cannot create"); + if (! log.isDirectory()) { + throw new IOException(config.logdir + ": cannot create"); + } + // If the directory IS there, all is well } File logfile = new File(config.logdir, "nc-" + ncId + ".log"); pb.redirectOutput(ProcessBuilder.Redirect.appendTo(logfile)); -- To view, visit https://asterix-gerrit.ics.uci.edu/890 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d3df0dbdb46df30b2e6467896e3a224cb7911a6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery <[email protected]> Gerrit-Reviewer: Chris Hillery <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]>
