Till Westmann has posted comments on this change. Change subject: Improve External Data ......................................................................
Patch Set 7: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/906/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java: Line 2003: mdTxnCtx); Why do we "get" something that's not used? Could we remove it or add a comment why this needs be be done? https://asterix-gerrit.ics.uci.edu/#/c/906/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java: Line 29: void appendPK(ArrayTupleBuilder tb) throws IOException; We append a PK to a parser? That sounds confusing ... https://asterix-gerrit.ics.uci.edu/#/c/906/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPRequestToRecordWithMetadataAndPKConverter.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPRequestToRecordWithMetadataAndPKConverter.java: Line 42: public class DCPRequestToRecordWithMetadataAndPKConverter This class name seems sub-optimal. -- To view, visit https://asterix-gerrit.ics.uci.edu/906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2560c73fa63e9454f731b8e893ae779a2ac7d9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
