Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1474: Cannot query dataset with big obj ......................................................................
Patch Set 2: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/920/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/IIOManager.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/io/IIOManager.java: Line 46: public long syncWrite(IFileHandle fHandle, long offset, ByteBuffer[] dataArray) throws HyracksDataException; > looking at this method definition, no one would guess that the dataArray is IIOManager is generic and can be used for lots of things, I don't think we would want to corrupt this interface with BufferCache's specific use pattern Line 50: public long syncRead(IFileHandle fHandle, long offset, ByteBuffer[] dataArray) throws HyracksDataException; > Remove unused? or comment future use? Done https://asterix-gerrit.ics.uci.edu/#/c/920/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java: Line 189: @Override > remove method? Done https://asterix-gerrit.ics.uci.edu/#/c/920/2/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/util/TreeIndexBufferCacheWarmup.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/util/TreeIndexBufferCacheWarmup.java: Line 47: > Am I seeing tabs?? Yes, I think we should remove tabs from files in a separate change (they're not being introduced here) https://asterix-gerrit.ics.uci.edu/#/c/920/2/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/util/TreeIndexStatsGatherer.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/util/TreeIndexStatsGatherer.java: Line 46: ITreeIndexFrame interiorFrame, ITreeIndexMetaDataFrame metaFrame) > Huh! how come Sonar doesn't detect those? Because they are not new. https://asterix-gerrit.ics.uci.edu/#/c/920/2/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ClockPageReplacementStrategy.java: Line 228: // TODO(mblow): is dropping pages on the floor enough to adhere to memory budget? > I believe it is enough. would be nice to find a better source to confirm Done -- To view, visit https://asterix-gerrit.ics.uci.edu/920 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f47c551a053e193519a4337c338934f3e171afd Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <michael.b...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <michael.b...@couchbase.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
