Michael Blow has posted comments on this change. Change subject: ASTERIXDB- 1479: Change storage valid int and add explicit version ......................................................................
Patch Set 8: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/919/8/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java: Line 475: return (long)(metadataPageNum * bufferCache.getPageSize()) + LIFOMetaDataFrame.LSN_OFF; > Well it's fixed as far as sonarQube is concerned :P it did complain at firs Yes, the addition would be a long operation, but I believe the multiplication are ints. If we ever have files that exceed 2GB, I think we can have an issue. -- To view, visit https://asterix-gerrit.ics.uci.edu/919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
