Michael Blow has posted comments on this change. Change subject: Use Maven Enforcer Plugin ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/929/2/hyracks-fullstack/pom.xml File hyracks-fullstack/pom.xml: Line 29: <groupId>org.apache</groupId> > Making the asterixdb POM dependent on the parent POM is OK, but we shouldn' It can be build independently of asterixdb, just not independent of the top-level pom. If you don't want this to be a pom that has references to the asterix modules, we can use a separate parent pom, but I think we should try to avoid having copy/paste configuration in both asterixdb & hyracks. e.g., you should able to rm -rf asterixdb, and the hyracks build should work. I'm not breaking that. https://asterix-gerrit.ics.uci.edu/#/c/929/2/pom.xml File pom.xml: Line 83: <version>3.3.9</version> > Can we make the constraint a lower bound? I'm not sure enforcing down to mi This syntax is lower bound. It means v >= 3.3.9. http://maven.apache.org/enforcer/enforcer-rules/versionRanges.html If it would be clearer, I can use the standard syntax for specifying this: [3.3.9,) -- To view, visit https://asterix-gerrit.ics.uci.edu/929 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-HasComments: Yes
