Yingyi Bu has posted comments on this change. Change subject: Fix Indexing on Open fields and Meta fields ......................................................................
Patch Set 6: (7 comments) 1. Can you add optimizer tests for those added runtime tests to verify index access path is used? 2. Can you add tests to check whether index join work? For that, you said " For joins and left outer joins, I have only created optimizer tests and not runtime tests.", but somehow they are not in this change. Are they on your local branch but not pushed? https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.1.ddl.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.1.ddl.aql: Line 21: * build a secondary index after the dataset has data WS https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.2.update.aql: Line 21: * build a secondary index after the dataset has data WS https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.3.ddl.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.3.ddl.aql: Line 21: * build a secondary index after the dataset has data WS https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.query.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.query.aql: Line 21: * build a secondary index after the dataset has data WS https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.5.ddl.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.5.ddl.aql: Line 21: * build a secondary index after the dataset has data Ws https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java: Line 95: hasMeta = true; replace the if-block with the following? hasMeta=(fieldPermutation.length > numOfPrimaryKeys + 1) &&(filterFieldIndex < 0 || (filterFieldIndex >= 0 && (fieldPermutation.length > numOfPrimaryKeys + 2))); https://asterix-gerrit.ics.uci.edu/#/c/930/6/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/dataflow/BTreeSearchOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/dataflow/BTreeSearchOperatorDescriptor.java: Line 70: throw new IllegalArgumentException(); Error message? -- To view, visit https://asterix-gerrit.ics.uci.edu/930 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
