Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1479: Change storage valid int and add explicit version ......................................................................
Patch Set 13: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/919/13/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java: Line 116: buf.putInt(FREE_SPACE_OFF, LSN_OFF + 8); This doesn't account for the storage version, does it? i.e. shouldn't this be STORAGE_VERSION_OFF + 4? Line 162: if (buf.getInt(VALID_OFF) == OBSOLETE_MAGIC_VALID_INT){ space before { ? -- To view, visit https://asterix-gerrit.ics.uci.edu/919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
