Yingyi Bu has posted comments on this change. Change subject: Support SELECT star. ......................................................................
Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/971/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java: Line 215: return processSelectClause(selectClause, selectBlock, currentOpRef); > Do we need to pass the selectClause and the selectBlock? Wouldn't it be suf Done https://asterix-gerrit.ics.uci.edu/#/c/971/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java: Line 63: return USER_VAR_PREFIX + varName.substring(1); > Why do we re-concatenate if the prefix is already there? Done. Inlined comments to explain that. -- To view, visit https://asterix-gerrit.ics.uci.edu/971 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa77431912670b55387fd5a722c2184341400a50 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
