Cameron Samak has posted comments on this change. Change subject: Remove duplicate operator symbol definition ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/979/1/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/struct/OperatorType.java: Line 59: return Arrays.stream(OperatorType.values()).filter(o -> o.symbol.equals(symbol)).findFirst(); > Maybe use a try-with-resources statement? I don't think that will do anything useful here. See https://docs.oracle.com/javase/8/docs/api/java/util/stream/Stream.html "nearly all stream instances do not actually need to be closed after use..." and https://jira.sonarsource.com/browse/SONARJAVA-1478 -- To view, visit https://asterix-gerrit.ics.uci.edu/979 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cfcf9a7e131d60a9b97fbc9fae3b762031c8edb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Cameron Samak <[email protected]> Gerrit-Reviewer: Cameron Samak <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
