Yingyi Bu has posted comments on this change. Change subject: QueryService API updates ......................................................................
Patch Set 19: (2 comments) Just one minor comment and one question. https://asterix-gerrit.ics.uci.edu/#/c/896/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java: Line 61: private static Logger LOGGER = Logger.getLogger(APIServlet.class.getName()); static final https://asterix-gerrit.ics.uci.edu/#/c/896/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java: Line 454: } What's the advantage of this method compared to previous way that has a final member compilationProvider in the class? -- To view, visit https://asterix-gerrit.ics.uci.edu/896 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5 Gerrit-PatchSet: 19 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
