Michael Blow has posted comments on this change. Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype based on parallel streaming histogram. ......................................................................
Patch Set 36: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/806/36/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/GlobalRangeGeneratorTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/GlobalRangeGeneratorTypeComputer.java: Line 30: public class GlobalRangeGeneratorTypeComputer extends AbstractResultTypeComputer { extra space before extends https://asterix-gerrit.ics.uci.edu/#/c/806/36/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarRangeGeneratorAggregateDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarRangeGeneratorAggregateDescriptor.java: Line 28: public final static FunctionIdentifier FID = AsterixBuiltinFunctions.SCALAR_RG; final static -> static final https://asterix-gerrit.ics.uci.edu/#/c/806/36/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractRangeGeneratorAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractRangeGeneratorAggregateFunction.java: Line 323: for (int i = 0; i < listItems.size(); i++) { Seems it might be a little cleaner to use the enhanced for loop: for (ARecordVisitablePointable item : listPointable.getItems()) ... Line 384: for (int i = 0; i < rangeMap.size(); i++) { Seems it might be a little cleaner to use the enhanced for loop here Line 409: for (int i = 0; i < rangeMap.size(); i++) { Seems it might be a little cleaner to use the enhanced for loop here Line 442: translateVal = (ShortPointable) BytePointable.FACTORY.createPointable(); bad cast (BytePointable) https://asterix-gerrit.ics.uci.edu/#/c/806/36/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java: Line 42: finishPartialResults(result); making sure this is the right method to call (partial) https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHeapList.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHeapList.java: Line 24: public void increase(int index, K key) throws HyracksDataException; can remove redundant 'public' modifier (all methods) https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHistogram.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHistogram.java: Line 27: * @author michael remove @author Line 30: public enum HistogramType { can remove redundant 'public' modifier (all enums & methods) https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IQuantileList.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IQuantileList.java: Line 27: public int size(); can remove redundant 'public' modifier (all methods) https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/DominantQuantile.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/DominantQuantile.java: Line 70: return super.hashCode(); Hashcode function should be implemented or this class may not behave as expected in a hashset/map. https://asterix-gerrit.ics.uci.edu/#/c/806/36/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/GenericQuantile.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/GenericQuantile.java: Line 73: return super.hashCode(); Hashcode function should be implemented or this class may not behave as expected in a hashset/map. -- To view, visit https://asterix-gerrit.ics.uci.edu/806 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01 Gerrit-PatchSet: 36 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
