Yingyi Bu has posted comments on this change.

Change subject: ASTERIX-1135 Fix Feed Policy Creation From File
......................................................................


Patch Set 2:

(2 comments)

Comments are inlined.  Maybe you can also add a SQL++ runtime test?

https://asterix-gerrit.ics.uci.edu/#/c/1018/2//COMMIT_MSG
Commit Message:

Line 7: ASTERIX-1135 Fix Feed Policy Creation From File
"ASTERIX-1135"->"ASTERIXDB-1135:"


https://asterix-gerrit.ics.uci.edu/#/c/1018/2/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:

Line 740:       }
Do you also need to fix this?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to