Michael Blow has posted comments on this change. Change subject: Extension Points For Servlets ......................................................................
Patch Set 2: (12 comments) https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java: Line 58: import static org.apache.asterix.api.http.servlet.ServletConstants.*; > Can we do non-* static includes? Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java: Line 46: import static org.apache.asterix.api.http.servlet.ServletConstants.*; > Can we do non-* static includes? Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java: Line 41: import static org.apache.asterix.api.http.servlet.ServletConstants.*; > Can we do non-* static includes? Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java: Line 56: import static org.apache.asterix.api.http.servlet.ServletConstants.*; > Can we do non-* static includes? Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryStatusAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryStatusAPIServlet.java: Line 39: import static org.apache.asterix.api.http.servlet.ServletConstants.*; > Can we do non-* static includes? Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java: Line 52: import static org.apache.asterix.api.http.servlet.ServletConstants.*; > Can we do non-* static includes? Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java: Line 38: import static org.apache.asterix.api.http.servlet.ServletConstants.*; > Can we do non-* static includes? Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java: Line 39: AsterixAppContextInfo props = (AsterixAppContextInfo) context.getAttribute(ServletConstants.ASTERIX_BUILD_PROP_ATTR); > MAJOR SonarQube violation: Done Line 39: AsterixAppContextInfo props = (AsterixAppContextInfo) context.getAttribute(ServletConstants.ASTERIX_BUILD_PROP_ATTR); > Static include for this one? Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java: Line 207: switch (key) { > If it were me, I'd have a method createServlet(Servlets key) that only has Done https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java: Line 43: import static org.mockito.Mockito.*; > Can we do non-* static includes? Done, but this is very annoying- IDEA seems to be malfunctioning here, I have it configured to only static import * when there are 99 items imported. Line 71: when(mockContext.getAttribute(ServletConstants.HYRACKS_CONNECTION_ATTR)).thenReturn(mockHcc); > Static includes for these? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1019 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff794b1c21296c50867b7430a0652924b5cf31d2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
