Yingyi Bu has posted comments on this change. Change subject: Implement EXPLAIN for SQL++ ......................................................................
Patch Set 4: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1020/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java: Line 51: private boolean wrap_array = false; camel case convention? Line 53: private boolean notfirst = false; camel case convention? https://asterix-gerrit.ics.uci.edu/#/c/1020/4/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java: Line 32: private boolean explain = false; make that part of the constructor so that we can set that right in visitors like DeepCopyVisitor? Line 109: public int hashCode() { make "explain" part of the hash code calculation? Line 120: } make "explain" part of the equality check? -- To view, visit https://asterix-gerrit.ics.uci.edu/1020 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
