Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1479: Change storage valid int and add explicit version ......................................................................
Patch Set 15: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/919/15/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java: Line 52: public static final int STORAGE_VERSION_OFFSET = HEADER_END_OFFSET + 8; //57 Essentially my same concern as in comments from patch 13 in initBuffer()- shouldn't HEADER_END be after the STORAGE_VERSION_OFFSET + 4, and shouldn't STORAGE_VERSION_OFFSET be STORAGE_VERSION_OFFSET + 8? -- To view, visit https://asterix-gerrit.ics.uci.edu/919 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
