Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1516: Unable to find free page in buffer cache after 3 cycles ......................................................................
Patch Set 1: (4 comments) >> Does JVM create a new object for a lambda expression like the following one? Not sure- I've removed them in case it does and it is expensive. https://asterix-gerrit.ics.uci.edu/#/c/1038/1/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: Line 370: while (cPage != null) { > This loop is repeated three times inside this method. You may refactor it a Done Line 1178: if (victim != null) { > I think if you do similar check in here as findPageInner, the code will be Done Line 1259: finally{ > formatting Done Line 1298: do { > do we need this do/while loop? It shuts up SonarQube, and doesn't cause any harm- I could add a comment to that affect. -- To view, visit https://asterix-gerrit.ics.uci.edu/1038 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46fa6bbda8c2f81e5e570dd6c07e4f4b794ef5bb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
