Till Westmann has posted comments on this change. Change subject: Support UNION ALL. ......................................................................
Patch Set 7: Code-Review+2 (2 comments) Feel free to forward the +2, if you decide to address the comments. https://asterix-gerrit.ics.uci.edu/#/c/1035/7/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java: Line 107: return bindingVars; Use an empty collection? https://asterix-gerrit.ics.uci.edu/#/c/1035/7/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java: Line 290: IPartitioningProperty dpp = delivered.getPartitioningProperty(); Do we need dpp here? -- To view, visit https://asterix-gerrit.ics.uci.edu/1035 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifadf1707bb2b6bed22f8fc5792c635e87291a468 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
