Jianfeng Jia has posted comments on this change. Change subject: Fix ASTERIXDB-1566 fix UTF8 comparator and hash function. ......................................................................
Patch Set 1: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1054/1//COMMIT_MSG Commit Message: Line 8: > "ASTERIXDB-1566"->"ASTERIXDB-1566: fix UTF8 comparator and hash function." Done https://asterix-gerrit.ics.uci.edu/#/c/1054/1/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/string-equal-public/string-equal-public.1.ddl.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/string/string-equal-public/string-equal-public.1.ddl.aql: Line 19: drop dataverse test if exists; > remove this file. Done https://asterix-gerrit.ics.uci.edu/#/c/1054/1/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/string-equal-public/string-equal-public.2.update.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/string/string-equal-public/string-equal-public.2.update.aql: Line 17: * under the License. > remove this file. Done https://asterix-gerrit.ics.uci.edu/#/c/1054/1/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/string-equal-public/string-equal-public.3.query.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/string/string-equal-public/string-equal-public.3.query.aql: Line 18: */ > rename this file to "string-equal-public.1.query.aql". Done Line 19: use dataverse test; > remove the dataverse reference. Done https://asterix-gerrit.ics.uci.edu/#/c/1054/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryComparatorFactoryProvider.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryComparatorFactoryProvider.java: Line 45: import org.apache.hyracks.data.std.primitive.*; > import each individual class. Done https://asterix-gerrit.ics.uci.edu/#/c/1054/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryHashFunctionFactoryProvider.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlBinaryHashFunctionFactoryProvider.java: Line 28: import org.apache.hyracks.data.std.primitive.*; > import each individual class. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1054 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I187bf1243abf143b3b265fa8098614b9a72c65ad Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
