Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1569: the config file now supports unit, comma, and decimal. ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1064/1/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/StorageUtil.java File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/StorageUtil.java: Line 108: unitType = StorageUnit.KILOBYTE; Could we make the parsing of strings to StorageUnits a method in StorageUnit (which probably should include the lowercasing)? -- To view, visit https://asterix-gerrit.ics.uci.edu/1064 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763d1b06e93f75775c0294da0d609c2bf3e102c9 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
