Yingyi Bu has posted comments on this change. Change subject: introduce AlgebraUtils and AlgebraUtils ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1069/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/util/AlgebraUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/util/AlgebraUtils.java: Line 32: public class AlgebraUtils { The name of this class is much larger than what it does. Line 34: private static IAObject getAsterixConstantValue(AbstractFunctionCallExpression f, int index, Add general functions take an ILogicalExpression as input and then wrap those for functioncall expression arguments if you want. https://asterix-gerrit.ics.uci.edu/#/c/1069/1/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangUtils.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangUtils.java: Line 27: public class LangUtils { Why should this be renamed? The new name implies a much larger scope than what this class actually does. -- To view, visit https://asterix-gerrit.ics.uci.edu/1069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0034bd6ba7f449a03eda48070a8de614608c2dd Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
