Till Westmann has posted comments on this change. Change subject: Index-only plan ......................................................................
Patch Set 23: Had another high-level look at this change and was think about how we can reduce the burden of a detailed review. I think that we should try to get this size of the diff down to be able to focus on the essential part. At its current size (+46060 lines, -14519 lines) it seems to be even too big for Gerrit to handle. Here are few things I noticed that could help: - Checked in merge conflict in asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java - There are a lot of whitespace changes in asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_parser.xml - There are a number of formatting changes e.g. in LSMRTreeOpContext that are moving from the format that I think our standard formatter uses to a different format. - Many files are changed because of the renaming of 'contains' to 'string-contains'. Creating a separate change for this renaming could reduce the of this change significantly and the separate change should be easy to review. - There are probably other changes (e.g. limit pushdown) that could be broken out into smaller chunks. Also, the regression tests are currently failing. -- To view, visit https://asterix-gerrit.ics.uci.edu/744 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa02c13d4fddd880e1ee9e85eef6577301fb4560 Gerrit-PatchSet: 23 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: No
