Michael Carey has posted comments on this change. Change subject: ASTERIXDB-1528: fix 101 query 6 and 7. ......................................................................
Patch Set 3: (2 comments) Just looked at this - suggested a very small wording change as well as an optional additional sentence. Same comment applies to both. https://asterix-gerrit.ics.uci.edu/#/c/1063/3/asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md File asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md: Line 692: select $fbu; I think the wording "no records that miss" would be better said via "no records with missing" -- English-wise. (It's not wrong, just awkward, as it currently is.) Thx! For extra credit, we could also take this opportunity to mention that another formulation could be is-unknown. Maybe something like "Another way to test the employment condition could be to use the is-unknown(.) function instead of is-missing; that approach would also allow for the case where $e.end-date is present but null-valued." https://asterix-gerrit.ics.uci.edu/#/c/1063/3/asterixdb/asterix-doc/src/site/markdown/aql/primer.md File asterixdb/asterix-doc/src/site/markdown/aql/primer.md: Line 690: Same comment here. -- To view, visit https://asterix-gerrit.ics.uci.edu/1063 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35bbf838b152bdfd56efd523961ec1dc0ca8322d Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
