Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1592: fix and regression tests. ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1110/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalGroupingProperty.java: Line 35: private List<LogicalVariable> preferredOrderEnforcer = new ArrayList<>(); > Could we make this final? Done Line 43: if (preferredOrderEnforcer != null) { > Do we still need this check, if there's a default value after construction? This check is for the input parameter, not the class member field. -- To view, visit https://asterix-gerrit.ics.uci.edu/1110 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id59ae2fd79302211973cfb3b82829eb3836da4bc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
