Steven Jacobs has posted comments on this change. Change subject: Compile a plan that matches user query in the case of nonpure functions ......................................................................
Patch Set 3: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1057/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: Line 229: List<IAType> matchedTypes = new ArrayList<IAType>(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1057/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 327: return new Pair<ILogicalExpression, Boolean>( > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1057/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java: Line 103: subTreeOpRef = subTreeOp.getInputs().get(0); > MAJOR SonarQube violation: Done Line 107: // Match (assign | unnest)+. > Comment does not match the code. Done https://asterix-gerrit.ics.uci.edu/#/c/1057/3/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java: Line 111: //Recursively look through function calls. > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1057/3/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java: Line 247: Set<LogicalVariable> liveVars = new HashSet<LogicalVariable>(); > MAJOR SonarQube violation: Done Line 248: List<LogicalVariable> usedVars = new ArrayList<LogicalVariable>(); > MAJOR SonarQube violation: Done Line 252: // However, if the op is already using variables that are not live, then a replacement may enable fixing the plan. > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1057/3/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetExecutionModeRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetExecutionModeRule.java: Line 55: // case LEFTOUTERJOIN: { > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1057 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
