Heri Ramampiaro has posted comments on this change. Change subject: Fulltext search initial implementation ......................................................................
Patch Set 14: Code-Review+1 (10 comments) Hi Taewoo. Sorry for my late review... Basically I want you check the usage of "instanceof", and whether this could be done more efficiently using "typetag" check instead. I also have a question related to treating lists... Best, -heri https://asterix-gerrit.ics.uci.edu/#/c/989/14/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 145: && arg2 instanceof ConstantExpression) { Since "instanceof" could cause a performance issues, can this be replaced with checking the tag of "arg2" instead? Line 224: if (objectFromExpr instanceof AString) { See my comment above... Line 227: } else if (objectFromExpr instanceof AOrderedList) { See my comment above... Line 232: if (objectFromExpr instanceof AString) { See my comment above... Line 239: } else if (objectFromExpr instanceof AUnorderedList) { See my comment above... Line 244: if (objectFromExpr instanceof AString) { See my comment above... https://asterix-gerrit.ics.uci.edu/#/c/989/14/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/AsterixConstantExpressionUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/AsterixConstantExpressionUtil.java: Line 69: if (obj instanceof AString) { Suggest using obj.getType() and typeTag instead Line 77: if (obj instanceof AOrderedList) { Suggest using obj.getType() and typeTag instead Line 85: if (obj instanceof AUnorderedList) { Suggest using obj.getType() and typeTag instead https://asterix-gerrit.ics.uci.edu/#/c/989/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonHelper.java: Line 704: case UNORDEREDLIST: Considering splitting this into different cases for future work? We could (should) for example treat [t1, t2, t3] and {{t2, t1, t3}} differently? -- To view, visit https://asterix-gerrit.ics.uci.edu/989 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71887c2ea847e4488f4c98a11f8a5bcad02cac5a Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
