Till Westmann has posted comments on this change. Change subject: Refactor Active Listeners ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1118/1/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java: Line 34: public boolean connectedToDataset(String dataverseName, String datasetName); Is this about the state of the listener or about the state of the active entity? If it's about the state of the entity, it should not be part of a listener interface. If it's about the listener, I'm not sure what it means to be connected to a dataset ... -- To view, visit https://asterix-gerrit.ics.uci.edu/1118 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I260c8608329523f56dc54780d87d796f838505cf Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
