Wenhai Li has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. ......................................................................
Patch Set 4: (8 comments) @Tawoo Will patch those issues soon. https://asterix-gerrit.ics.uci.edu/#/c/1076/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixExtractFunctionsFromJoinConditionRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixExtractFunctionsFromJoinConditionRule.java: Line 45: public class AsterixExtractFunctionsFromJoinConditionRule extends ExtractFunctionsFromJoinConditionRule { > Can we put detailed explanation here? What does this rule do and why it is Done https://asterix-gerrit.ics.uci.edu/#/c/1076/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java: Line 124: // GROUPBY_LEFT, GROUPBY_RIGHT > If the group_by will be added later, we can remove this comment. Done Line 129: // JOIN_COND_RIGHT JOIN_COND_LEFT > This too. Done Line 157: // Currently, we limit the prefix based fuzzy join times so as to restrict the memory assumption. > Remove this comment. Done Line 220: // Avoid the duplicated pk generation in findPrimaryKeysInSubplan, especially for multiway fuzzy join. > Can we put an example here? We can exemplify this offline? https://asterix-gerrit.ics.uci.edu/#/c/1076/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java: Line 256: public class InlineSubplanInputForNestedTupleSourceRule implements IAlgebraicRewriteRule { > Why does "hasRun" boolean variable need to be deleted? Omm, if the subplan is inlined by another subplan, this rule will return directly, without further handling the subplan. Once we setup multiple join more than three-way, this issue will make the generated plan nested and will result in group by inlined by subplan error in algebricks. https://asterix-gerrit.ics.uci.edu/#/c/1076/4/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractFunctionsFromJoinConditionRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractFunctionsFromJoinConditionRule.java: Line 66: throws AlgebricksException { > Format issue? There is no actual change. You may replace this file with the Done Line 108: new MutableObject<ILogicalExpression>(exprRef.getValue().cloneExpression())); > Format issue? There is no actual change. You may replace this file with the Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-HasComments: Yes
