Till Westmann has posted comments on this change. Change subject: Add Helper Client To Interface With Cluster HTTP APIs ......................................................................
Patch Set 1: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1126/1/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/ClusterHelper.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/ClusterHelper.java: Line 2: * Copyright 2016 Couchbase, Inc. I think that we should just have the regular "Licensed to the Apache Software Foundation ..." header here. Line 33: CmdLineParser parser = new CmdLineParser(options); use new CmdLineParser(options, ParserProperties.defaults().withUsageWidth(120)) instead and avoid the deprecated setUsageWidth(120) below? https://asterix-gerrit.ics.uci.edu/#/c/1126/1/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/Options.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/Options.java: Line 2: * Copyright 2016 Couchbase, Inc. I think that we should just have the regular "Licensed to the Apache Software Foundation ..." header here. https://asterix-gerrit.ics.uci.edu/#/c/1126/1/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/commands/ClientCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/commands/ClientCommand.java: Line 2: * Copyright 2016 Couchbase, Inc. I think that we should just have the regular "Licensed to the Apache Software Foundation ..." header here. https://asterix-gerrit.ics.uci.edu/#/c/1126/1/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/commands/GetClusterStateCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/commands/GetClusterStateCommand.java: Line 2: * Copyright 2016 Couchbase, Inc. I think that we should just have the regular "Licensed to the Apache Software Foundation ..." header here. https://asterix-gerrit.ics.uci.edu/#/c/1126/1/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/commands/ShutdownCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/commands/ShutdownCommand.java: Line 2: * Copyright 2016 Couchbase, Inc. I think that we should just have the regular "Licensed to the Apache Software Foundation ..." header here. https://asterix-gerrit.ics.uci.edu/#/c/1126/1/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/commands/WaitForClusterCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/helper/commands/WaitForClusterCommand.java: Line 2: * Copyright 2016 Couchbase, Inc. I think that we should just have the regular "Licensed to the Apache Software Foundation ..." header here. -- To view, visit https://asterix-gerrit.ics.uci.edu/1126 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
