Till Westmann has posted comments on this change. Change subject: Add Helper Client To Interface With Cluster HTTP APIs ......................................................................
Patch Set 9: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java: Line 95: public abstract int execute(); Should we have this one throw an IOException and save some exception wrapping in the subclasses? https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/GetClusterStateCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/GetClusterStateCommand.java: Line 50: // TODO (mblow): interrogate result to determine cluster readiness, not rely on HTTP 200 That'd be nice - I'm not sure that the codes are reliable https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ShutdownCommand.java File asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ShutdownCommand.java: Line 53: // TODO (mblow): interrogate result to determine acceptance, not rely on HTTP 200 That'd be nice - I'm not sure that the codes are reliable. However, I'm also not sure if the shutdown servlet returns something useful ... https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh File asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh: Line 19: # reserved. s/2006/2016/ ? Or remove the copyright and put the "normal" header? https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh File asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh: Line 19: # reserved. s/2006/2016/ ? Or remove the copyright and put the "normal" header? Line 49: echo " wait for CCDriver to terminate if running." only one space between echo and " -- To view, visit https://asterix-gerrit.ics.uci.edu/1126 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
