Michael Blow has posted comments on this change. Change subject: Small Cleanup ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1145/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalDataSourceFactory.java: Line 92: throw new AlgebricksException("Configurations don't have any stores"); What are the multiple configurations? Should this be Configuration doesn't? Line 95: while (i < count) { if a label (e.g. outer) is added to this while, you can keep the foreach and just add the break outer when incrementing i below, and you can remove all the intermediate && i < count checks Line 102: i++; e.g. if (++i == count) { break outer; } -- To view, visit https://asterix-gerrit.ics.uci.edu/1145 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib527f2eee283faf75c04323b6961c31a6d739d07 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes