Till Westmann has posted comments on this change. Change subject: Access To Node Configuration & Statistics ......................................................................
Patch Set 1: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1147/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java: Line 242: ServletMapping mapping = new ServletMapping(); What does this add? https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientConnection.java: Line 34: import org.json.JSONObject; Would be nice not to have a dependency on JSONObject in this interface. Line 197: *@param includeConfig @return {@link JSONObject} containing the node details WS Line 200: public String getNodeDetailsJSON(String nodeId, boolean includeStats, boolean includeConfig) throws Exception; It seems that we don't use this method. Do we need to expose it on the Hyracks client connection? Is this access useful for extensions? https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/IHyracksClientInterface.java: Line 59: public String getNodeDetailsJSON(String nodeId, boolean includeStats, boolean includeConfig) throws Exception; This also seems to be unused. https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java: Line 291: if (includeConfig) { How do I access add this information from the HTTP API? Do we have docs/a test? https://asterix-gerrit.ics.uci.edu/#/c/1147/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeDetailsJSONWork.java: Line 56: detail = ncs.toDetailedJSON(includeStats, includeConfig); Conditional expression? -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
