Michael Blow has posted comments on this change. Change subject: Extend Cluster API Servlet, += Config / Stats ......................................................................
Patch Set 3: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1147/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java: Line 73: throw new IllegalArgumentException(); > Shouldn't we just get a 404 here, ff the path (URL) is not valid? Done Line 88: throw new IllegalArgumentException("unknown nc: " + node); > Same here? Done Line 100: throw new IllegalArgumentException(); > Or here? Done Line 125: throw new IllegalArgumentException("unknown nc: " + node); > Or here? Done https://asterix-gerrit.ics.uci.edu/#/c/1147/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java: Line 76: import static org.apache.asterix.api.http.servlet.ServletConstants.HYRACKS_CONNECTION_ATTR; > Wow, these sure seem to be moving around :) Do we have a convention? Eclipse and IDEA's defaults seem to disagree... -- To view, visit https://asterix-gerrit.ics.uci.edu/1147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7549f2bb0b6621886356d50df800d447928aa2c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
