Till Westmann has posted comments on this change. Change subject: Expose Asterix Configuration on Cluster Servlet ......................................................................
Patch Set 1: (3 comments) Very nice! But I think that we should also add a test of 2. It seems that the TestExecutor already has some support for testing this endpoint - not sure if we also have tests for it ... https://asterix-gerrit.ics.uci.edu/#/c/1153/1/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixReplicationProperties.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixReplicationProperties.java: Line 198: @PropertyKey("replication.factor") Introduce a constant? Line 209: @PropertyKey("replication.timeout") Introduce a constant? Line 260: @PropertyKey("replication.max.remote.recovery.attempts") Introduce a constant? -- To view, visit https://asterix-gerrit.ics.uci.edu/1153 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I828d6a61afe615f7826079ede4b1d638bbd7ac5d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
