abdullah alamoudi has posted comments on this change. Change subject: Small Cleanup Towards Fixing LifeCycle Issues ......................................................................
Patch Set 4: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1148/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java: Line 61: ncs.sendApplicationMessageToCC(JavaSerializationUtils.serialize(message), null); > Why is the callback mechanism removed? Did you discuss with Murtadha? I did discuss it with Murtadha, instead of the callback, the return message should be the callback itself. The functionality is still there and this is much cleaner. https://asterix-gerrit.ics.uci.edu/#/c/1148/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycle.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycle.java: Line 39: public class DatasetLifecycle implements Comparable<DatasetLifecycle> { > The name is confusing. An object lifecycle is the time between creation and I actually have renamed this already on my local branch to DatasetResource https://asterix-gerrit.ics.uci.edu/#/c/1148/4/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java: Line 77: //how is this right?????????? <needs to be fixed> > Please file an Issue. Rarely do we remember comments in the code. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1148 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84005a33837725f41ae63297a3711215dccce1d8 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
