Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1451: Remove Record Casting for insert/delete/upsert ......................................................................
Patch Set 5: Code-Review+1 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1146/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java: Line 208: Map<IndexFieldId, LogicalVariable> fieldVarsForBeforeOperation = new HashMap<>(); Can you add some comments to describe what those two maps are used for? E.g., "for the situation there are multiple composite key indexes...." This will help me a lot to understand injectFieldAccessesForIndexes(...)? (I have been staring on those for some time but couldn't understand the purpose of them:-)) -- To view, visit https://asterix-gerrit.ics.uci.edu/1146 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a80105798ea1c86a6a0eb69a79b9573b54931b7 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
