Jianfeng Jia has posted comments on this change. Change subject: Adding a new 101 tutorial for SQL++. ......................................................................
Patch Set 1: (7 comments) Looks good to me. All comments are more about the SQL++ syntax itself than the contents. Some syntax is a little hard for me to follow at the first glance. Don't know if it worth explaining for newbies like me. https://asterix-gerrit.ics.uci.edu/#/c/1131/1/asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md File asterixdb/asterix-doc/src/site/markdown/sqlpp/primer-sqlpp.md: Line 87: DROP DATAVERSE TinySocial IF EXISTS; Are all reserved keywords required to be uppercase? Line 92: screenName: string, Can these type tags be uppercase? Line 194: SELECT VALUE ds FROM Metadata.`Dataset` ds; why there are two `ds` here? Line 195: SELECT VALUE ix FROM Metadata.`Index` ix; why are we using backquote? Line 434: SELECT user.name AS uname, msg.message AS message why we don't have VALUE if accessing the field? Line 532: { "uname": "IsbelDull", "message": " like t-mobile its platform is mind-blowing" } what would be the result be if the select without `AS` ? SELECT user.name , msg.message Line 798: USE TinySocial; this line should be indented? -- To view, visit https://asterix-gerrit.ics.uci.edu/1131 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I299b4947b928f301e8fdca8522d9a9f1e6a772cb Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Carey <dtab...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
