Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1566, ASTERIXDB-1628: Fixed External Hash Group By to conform to the memory budget ......................................................................
Patch Set 10: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/1056/10/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java: Line 413: int numberOfHeaderFrame = (int) Math.ceil(tableSize * 2 / frameSize); > MAJOR SonarQube violation: Done Line 413: int numberOfHeaderFrame = (int) Math.ceil(tableSize * 2 / frameSize); > CRITICAL SonarQube violation: Done Line 414: int numberOfContentFrame = (int) Math > MAJOR SonarQube violation: Done Line 415: .ceil((getNumberOfEntryInSlot() * 2 * getUnitSize() * tableSize) / frameSize); > CRITICAL SonarQube violation: Done Line 445: int slotCapacity = 0; > MAJOR SonarQube violation: Done Line 446: int slotUsedCount = 0; > MAJOR SonarQube violation: Done Line 447: int capacityInIntCount = 0; > MAJOR SonarQube violation: Done Line 462: slotCapacity = INVALID_VALUE; > MAJOR SonarQube violation: Done Line 463: slotUsedCount = INVALID_VALUE; > MAJOR SonarQube violation: Done Line 549: intReadAtThisTime = Math.min(intToRead, (frameCapacity - currentReadIntOffsetInPageForGC)); > MAJOR SonarQube violation: Done Line 580: oneTimeIntCapacityForWriter = Math.min(chunksToMove, (frameCapacity - tempWriteIntPosInPage)); > MAJOR SonarQube violation: Done Line 581: oneTimeIntCapacityForReader = Math.min(chunksToMove, (frameCapacity - tempReadIntPosInPage)); > MAJOR SonarQube violation: Done Line 639: chunksToDeleteAtThisTime = Math.min(chunksToDelete, (frameCapacity - tempReadIntPosInPage)); > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Wenhai Li <lwhaym...@yahoo.com> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
