Michael Blow has posted comments on this change.

Change subject: avoid some exception wrapping
......................................................................


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1179/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 334:                 throw new AlgebricksException("Unexpected 
OutputFormat!");
/!"/: " + conf.fmt()/


https://asterix-gerrit.ics.uci.edu/#/c/1179/1/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java
File 
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/management/AsterixEventServiceClient.java:

Line 162:                 throw new 
Exception(report.getException().getMessage());
> CRITICAL SonarQube violation:
Why not throw report.getException()?  This is still wrapping and in the case of 
many exceptions losing a lot of information.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1179
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8fff04c314eb146ce0a73beb0b8ec412cb2d280
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-HasComments: Yes

Reply via email to