Till Westmann has posted comments on this change.

Change subject: Add Default Dataverse and AnyObject Datatype
......................................................................


Patch Set 8:

(1 comment)

There are still a lot of deleted ASTs in this change. It seems that we should 
have 1 AST per AQL/SQL++ source file and that we should compare all of those 
AST for these tests. So I'm wondering if the AST files that are removed right 
now have a matching source file or now.

https://asterix-gerrit.ics.uci.edu/#/c/1174/8/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java:

Line 104:                         if (e instanceof ComparisonException) {
This instanceof check is a relatively bad hack that I used to document a 
problem, I don't think that we should use it here (instead we should probably 
have more than one catch-clause ...).
However, it seems to me that the introduction of the ComparisonException (or 
something similar) is helpful as it enables us to identify exceptions that are 
thrown to indicate unexpected request behavior.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1174
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02c74c8b005dce73888afd4dfe19ede2c60a8e8
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to