Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1631: let TypeComputeUtils handle input type ANY properly. ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1191/2//COMMIT_MSG Commit Message: Line 7: ASTERIXDB-1631: let TypeComputeUitls handle input type ANY properly. > s/TypeComputeUitls/TypeComputeUtils/ Done https://asterix-gerrit.ics.uci.edu/#/c/1191/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java: Line 127: } else if (inputTypeTag == ATypeTag.ANY) { > Could we switch on inputType.getTypeTag()? Done https://asterix-gerrit.ics.uci.edu/#/c/1191/2/asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java File asterixdb/asterix-om/src/test/java/org/apache/asterix/om/typecomputer/TypeComputerTest.java: Line 105: IAType resultType = instance.computeType(mockExpr, mockTypeEnv, mockMetadataProvider); > Running through the tests a saw a few result types, that were UNION types w Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1191 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6b3f0e9d9b4ddd9280e06f72a5ca30aa776315d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes