Till Westmann has posted comments on this change.

Change subject: Add aliases for several builtin types and builtin functions.
......................................................................


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1199/2//COMMIT_MSG
Commit Message:

Line 13: - year_month_duration for year_month_duration
s/year_month_duration/year-month-duration/


https://asterix-gerrit.ics.uci.edu/#/c/1199/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/AsterixBuiltinTypeMap.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/AsterixBuiltinTypeMap.java:

Line 38: public class AsterixBuiltinTypeMap {
Could we rename this to BuiltinTypeMap? "Asterix" is already part of the 
package name.


Line 43:         // Builtin types with deprecated names.
How do we track which types are deprecated? Do we have/need an issue for this?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1199
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4a933f9775e89c2d503d9ea1cb98c5934d1475
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyin...@gmail.com>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to